Note linking #223
Merged
Note linking #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverich
commented
Aug 26, 2024
| @@ -364,14 +364,36 @@ function createBreak(node: mdast.Break) { | |||
|
|
|||
| export type Link = ReturnType<typeof createLink>; | |||
|
|
|||
| const noteLinkRegex = /^\.\/(?:(.+)\/)?([a-zA-Z0-9-]+)\.md$/; | |||
There was a problem hiding this comment.
Document implications of this. Should this live in the features/not-ref directory?
cloverich
commented
Aug 26, 2024
src/views/edit/PlateContainer.tsx
Outdated
| createNoteRefPlugin, | ||
| } from "./editor/features/note-ref/createNoteRefPlugin"; | ||
|
|
||
| import { createNotRefElementPlugin } from "./editor/features/note-ref/createNoteRefElementPlugin"; |
There was a problem hiding this comment.
NOTERef; organize exports
cloverich
force-pushed
the
note_linking
branch
3 times, most recently
from
a68fd69 to
f1da4b6
Compare
- Adds the ability to link from one note to another, using the @ symbol. - Pilots using a "feature" folder to colocate all feature code (plugin, element, mdast) - Inlines several dependencies to support light customization or ease debugging - ariakit combobox is intended to be temporary, refactored in or out in upcoming dropdown / tag input refactor
cloverich
force-pushed
the
note_linking
branch
from
f1da4b6 to
3869740
Compare
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add linking from one note to another. Uses the
@symbol to trigger the dropdown menu, which provides note search functionality. On selecting a note, copy a reference to it, serialized as a link in the form of../<journal_id>/<note_id>.md. The menu looks like:When selecting an item, link will be embedded into the note; I ended up changing the color slightly to indicate its a note link. Did not put a ton of thought into the design here, want to use it in anger to organize my thoughts on it.
A couple of notes on some of the design choices:
<notesdir>/<journal_id>/<note_id>.Closes #124
Follow-up work: